Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #9294 bug(nimbus): Use correct channel for monitor-web fml #9295

Merged
merged 1 commit into from Aug 21, 2023
Merged

fixes #9294 bug(nimbus): Use correct channel for monitor-web fml #9295

merged 1 commit into from Aug 21, 2023

Conversation

brennie
Copy link
Member

@brennie brennie commented Aug 18, 2023

Because

This commit

  • updates make convert_feature_manifests to use the correct channel; and
  • merges the updated feature manifests from monitor and desktop.

jeddai
jeddai requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@jeddai jeddai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small adjustment and it should be good

Makefile Outdated Show resolved Hide resolved
@brennie brennie force-pushed the dev/barret/fix-monitor-yaml branch from cfeb591 to 816097a Compare August 18, 2023 20:49
@brennie brennie force-pushed the dev/barret/fix-monitor-yaml branch from 816097a to 1d53a36 Compare August 18, 2023 20:49
@brennie brennie added this pull request to the merge queue Aug 18, 2023
jaredlockhart
jaredlockhart approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2023
@eliserichards eliserichards added this pull request to the merge queue Aug 21, 2023
Merged via the queue into main with commit 5984019 Aug 21, 2023
15 checks passed
@eliserichards eliserichards deleted the dev/barret/fix-monitor-yaml branch August 21, 2023 16:54
@brennie brennie mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart approved these changes

@jeddai jeddai jeddai approved these changes

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana

@eliserichards eliserichards Awaiting requested review from eliserichards

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brennie @jaredlockhart @jeddai @eliserichards