Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error propagation for rules during vectorization #163

Open
danielhertenstein opened this issue Nov 8, 2019 · 0 comments
Open

Comments

@danielhertenstein
Copy link
Collaborator

We have found that during vectorization of pages (running the ruleset on a page using FathomFox), if a rule errors and never returns, the resulting vectors returned by Fathom are malformed. They may be empty (returning []) or Fathom may not return a set of vectors at all. This problem requires additional investigation to identify the complete behavior. Regardless, we need to add better error propagation so an error is returned to FathomFox instead of malformed vectors.

It is likely the work involved here will be helpful in completing #134 and #135.

See this comment chain for additional context: mozilla/fathom-fox#55 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant