Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Characterize Chrome's distraction-free-browsing mode #2

Closed
erikrose opened this issue Mar 18, 2016 · 2 comments
Closed

Characterize Chrome's distraction-free-browsing mode #2

erikrose opened this issue Mar 18, 2016 · 2 comments

Comments

@erikrose
Copy link
Contributor

How does Chrome identify what's a distraction and what's not? Summarize on a new ChromeDistractionFreeBrowsing page.
@pelmers
Copy link

pelmers commented Mar 27, 2016

Started drafting at https://github.com/mozilla/snuffy/wiki/ChromeDistractionFreeBrowsing.

I just put down an overview, I haven't really looked at the gritty details of its heuristics.

@erikrose
Copy link
Contributor Author

Looks great! Incidentally, her source is some of the most readable C++ I've ever encountered, due to her use of modern C++ features and the low-impedance-mismatch API she's programming against.

Their approach is clearly more complicated than Readability's, but they do more as well, finding prev (not just next) buttons and "lead images". Good stuff.

@erikrose erikrose added the wiki label May 10, 2016
@erikrose erikrose added wiki and removed wiki labels Jan 26, 2017
erikrose pushed a commit to erikrose/fathom that referenced this issue Mar 24, 2020
@globau
optimise updateProgress (fixes mozilla#2)
f22cd42 
Make updateProgress faster by minimising the times elements are added
and removed from the DOM, and cache the element objects instead of
looking them up for each call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikrose @pelmers