This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
Bug 1054303 - Use open search plugins for search engines #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public void testResultsUri() { | ||
| final String expected = "http://www.google.com/search?q=query&ie=utf-8&oe=utf-8&aq=t"; | ||
| assertEquals(expected, engine.resultsUriForQuery("query")); |
There was a problem hiding this comment.
If url params change order, this could create a false negative. I think the .equals method of Uri could help to insulate from param order:
http://developer.android.com/reference/android/net/Uri.html#equals%28java.lang.Object%29
There was a problem hiding this comment.
Good idea. I realized these tests were pretty fragile, but at least they would be fragile in the false-positive failure direction ;)
leibovic
force-pushed
the
opensearch
branch
5 times, most recently
from
53708de
to
1613ca4
Compare
leibovic
added a commit
that referenced
this pull request
Aug 25, 2014
Bug 1054303 - Use open search plugins for search engines. r=bnicholson
|
|
||
| public class SearchEngineManager implements SharedPreferences.OnSharedPreferenceChangeListener { | ||
| private static final String LOG_TAG = "SearchEngineManager"; | ||
| private final static String LOG_TAG = "SearchEngineManager"; |
There was a problem hiding this comment.
Oops, I must have done that in different iterations that removed/added this line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a WIP, but I wanted to open a pull request to share my progress.