This repository has been archived by the owner on Jul 12, 2018. It is now read-only.
Add more locales to FHR to avoid 404 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have several locales shipping in Aurora or Beta/Release not enabled in FHR: gn, lo, ltg, ne-NP, tl. They're currently not translated, but we should at least show en-US content for them, not a 404 page.
|
I think @georgf can review this |
georgf
approved these changes
Feb 15, 2017
|
Verified on dev server that all locales added here are not 404 anymore. e.g. https://fhr-dev.allizom.org/ne-NP/v4/ vs https://fhr.cdn.mozilla.net/ne-NP/v4/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several locales shipping in Aurora and one, Guaraní, even in Beta/Release not enabled in FHR: gn, lo, ltg, ne-NP, tl.
They're currently not translated, but we should at least show en-US content for them, not a 404 page (is there data about people hitting those?)
Diff is bigger, but it's generated by editor cutting the list at 80 characters instead of the existing manual formatting.