Skip to content
This repository has been archived by the owner on Jul 12, 2018. It is now read-only.

Bug 1328572 - Use document fragments when building the list of pings. #180

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Bug 1328572 - Use document fragments when building the list of pings. #180

merged 1 commit into from
Feb 15, 2017

Conversation

Dexterp37
Copy link
Contributor

No description provided.

@Dexterp37 Dexterp37 self-assigned this Feb 15, 2017
@flodolo
Copy link
Contributor

flodolo commented Feb 15, 2017

Tested on local VM[1], with a profile that contains about 2400 pings. According to DevTools network panel:

  • Local VM with current master: ~14s
  • Local VM with this patch applied: ~12s
  • Local VM @ b6717cc: ~48s 😭

[1] really limited specs, using PHP internal server to serve the web folder, poor performances are expected

@Dexterp37
Copy link
Contributor Author

Thank you Francesco! @georgf , it looks like this patch is still helpful (as it chops of ~2s).

georgf
georgf approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@georgf georgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement, thanks.

@georgf georgf merged commit c8048a4 into mozilla:master Feb 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgf georgf georgf approved these changes

Assignees

@Dexterp37 Dexterp37

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dexterp37 @flodolo @georgf