Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docs to be more approachable #130

Merged
merged 4 commits into from
May 7, 2018

Conversation

harterrt
Copy link
Contributor

@harterrt harterrt commented May 3, 2018

No description provided.

* Move Dataset reference to their own section
* Remove duplicate links (Fixes #103)
* Merge Data Privacy and Data Collection documents
* Move some Cookbooks out from the Tools section
* Clean up READMEs
* Convert straggling .adoc files to .md
* Move "Reporting a problem" to it's own article for visibility
* Reflect structure changes made in previous commit
@harterrt harterrt changed the title Make docs more approachable with refactor Refactor docs to be more approachable May 3, 2018
@harterrt harterrt requested a review from mreid-moz May 3, 2018 18:52
@harterrt
Copy link
Contributor Author

harterrt commented May 3, 2018

See commit messages for an enumeration of the changes. This is part of a larger annual review of the Documentation.

Copy link
Contributor

@mreid-moz mreid-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice refactor! A few minor issues to clean up, but overall looks good.


### Problems with the data

There are bugzilla components for several of core [datasets](datasets/README.adoc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should link to datasets/reference.md


### Problems with tools

There are bugzilla components for several of the [tools](tools/README.adoc) that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should link to tools/README.md (or maybe better tools/interfaces.md)

introduction.md Outdated

### [Cookbooks & Tutorials](cookbooks/README.md)
This section contains tutorials presented in a simple problem/solution format.

### [Data Collection and Datasets](datasets/README.adoc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should link to datasets/reference.md

To run the spell checker locally, [install the `markdown-spellcheck` library](https://www.npmjs.com/package/markdown-spellcheck), then run the following command from the root of the repository:
To run the spell checker locally,
[install the `markdown-spellcheck` library](https://www.npmjs.com/package/markdown-spellcheck),
then run the `scripts/spell_check.sh` script from the root of the repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 moving this command into a separate script!

.spelling Outdated
@@ -108,6 +108,7 @@ pushlog
PySpark
RDBMS
RDD
realtime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition is not needed (spell check passes without it, and the prose uses "real-time").

Copy link
Contributor

@mreid-moz mreid-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mreid-moz mreid-moz merged commit f5d755c into mozilla:master May 7, 2018
@harterrt harterrt deleted the summary_refactor branch May 10, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants