This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Enhance and fix the prefs module for all the features we need (#39) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with self.marionette.using_context('chrome'): | ||
| return self.marionette.execute_script(""" | ||
| Cu.import("resource://gre/modules/Services.jsm"); | ||
| let prefBranch = Services.prefs.QueryInterface(Ci.nsIPrefBranch); |
There was a problem hiding this comment.
We know what Services.prefs supports, so is the QI necessary here?
There was a problem hiding this comment.
Good catch! You are right, it also QI's it itself. So we should be able to remove that.
|
Overall this looks good if you want to fixup and merge. Happy to discuss check it out again if you prefer. |
|
Thanks Chris! I pushed another commit with all the review comments included. Before I merge this in I want to enhance the documentation for this module. |
|
I pushed a new commit with the API docs. I haven't added examples yet, which we can do later once it's more clear how to structure the docs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #39. @chmanchester can you please have a look? With all the changes we have everything what we need and are nearly identical with the mozmill prefs module, except for setting complex preferences. Checking our Mozmill tests I actually haven't found any instance so far where this would be necessary. Means I'm happy to not include it right now.