Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nimbledroid endpoint #39

Closed
armenzg opened this issue Jul 4, 2018 · 1 comment
Closed

Add Nimbledroid endpoint #39

armenzg opened this issue Jul 4, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@armenzg
Copy link
Contributor

armenzg commented Jul 4, 2018

CC @njpark @wlach

This is to support this issue on the frontend.

I've considered not implementing this API on the backend since we could have just used the frontend and cache it, however, there are some reasons I want to document as to why I believe it should be done on the backend.

  • Fetching directly from Nimbledroid (public sample gist) takes a long time which would have meant a very slow first load for the client
  • The compressed transfer is less than 200KB and 2MB on disk. I will be dropping the console_message from each entry to reduce the data size. If we need it we can add it later.
  • We can add a Heroku scheduler to warn up the cache in advance. This will improve the client's first load time
@armenzg armenzg added the enhancement New feature or request label Jul 4, 2018
@armenzg armenzg self-assigned this Jul 4, 2018
armenzg added a commit that referenced this issue Jul 4, 2018
* Add documentation to enable Nimbledroid fetching
* Heroku review app configuration changes to copy Nimbledroid env variables
* Add /api/android/nimbledroid endpoint
* Add central configuration file
* Switch from 'node-fetch' to 'isomorphic-fetch' to support tests with 'fetch-mock'
* Add Nimbledroid tests
armenzg added a commit that referenced this issue Jul 5, 2018
* Add documentation to enable Nimbledroid fetching
* Heroku review app configuration changes to copy Nimbledroid env variables
* Add /api/android/nimbledroid endpoint
* Add central configuration file
* Switch from 'node-fetch' to 'isomorphic-fetch' to support tests with 'fetch-mock'
* Add Nimbledroid tests
armenzg added a commit that referenced this issue Jul 5, 2018
* Add documentation to enable Nimbledroid fetching
* Heroku review app configuration changes to copy Nimbledroid env variables
* Add /api/android/nimbledroid endpoint
* Add central configuration file
* Add Nimbledroid tests
armenzg added a commit that referenced this issue Jul 9, 2018
* Add documentation to enable Nimbledroid fetching
* Heroku review app configuration changes to copy Nimbledroid env variables
* Add /api/android/nimbledroid endpoint
* Add central configuration file
* Add Nimbledroid tests
armenzg added a commit that referenced this issue Jul 9, 2018
* Add documentation to enable Nimbledroid fetching
* Heroku review app configuration changes to copy Nimbledroid env variables
* Add /api/android/nimbledroid endpoint
* Add central configuration file
* Add Nimbledroid tests
armenzg added a commit that referenced this issue Jul 10, 2018
* Add documentation to enable Nimbledroid fetching
* Heroku review app configuration changes to copy Nimbledroid env variables
* Add /api/android/nimbledroid endpoint
* Add central configuration file
* Add Nimbledroid tests
@armenzg
Copy link
Contributor Author

armenzg commented Jul 15, 2018

This landed few days ago.

@armenzg armenzg closed this as completed Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant