Bug 1165103 - Use a separate AppDelegate for Aurora builds #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebnich
force-pushed
the
aurora-app-delegate
branch
2 times, most recently
from
2628fd7
to
d6ebed7
Compare
|
|
||
| private var appDelegate: AppDelegate.Type | ||
|
|
||
| if AppConstants.IsRunningTest { |
There was a problem hiding this comment.
I think it could be nice if we had an enum containing the Build or Channel type. What do you think?
thebnich
force-pushed
the
aurora-app-delegate
branch
from
d6ebed7
to
24a2489
Compare
|
@st3fan, I updated to use a |
thebnich
force-pushed
the
aurora-app-delegate
branch
from
24a2489
to
3978cd0
Compare
thebnich
added a commit
that referenced
this pull request
May 19, 2015
Bug 1165103 - Use a separate AppDelegate for Aurora builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the same
AppDelegatepattern being used in bug 1162999.