Bug 1123055: Respect "Darken colors" accessibility setting #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not yet support responding to notifications of changes to the setting.
thebnich
added a commit
that referenced
this pull request
Jan 21, 2015
Bug 1123055: Respect "Darken colors" accessibility setting
|
Thanks. We should probably create a theme class to group this stuff together instead of having colors/accessibility checks spread out everywhere, but this should be OK for now. |
|
My thoughts too about some theme class. More when I consider what will need to be done with fonts, as based on different accessibility (or partly accessibility) settings, we might choose to use:
I will log these two as bugs in the coming days. |
isabelrios
pushed a commit
to isabelrios/firefox-ios
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not yet support responding to notifications of changes to the
setting.
The only changes that I could test were in "Share To" and in History
table, as other parts of UI seem not to work yet.