Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Cancel all" action doesn't work #250

Open
Tracked by #311
eu9ene opened this issue Nov 8, 2023 · 8 comments
Open
Tracked by #311

"Cancel all" action doesn't work #250

eu9ene opened this issue Nov 8, 2023 · 8 comments
Assignees
@bhearsum
Labels
taskcluster Issues related to the Taskcluster implementation of the training pipeline tc-p1 Important Taskcluster issues to fix soon

Comments

@eu9ene
Copy link
Collaborator

eu9ene commented Nov 8, 2023

I have to cancel tasks separately now.

Screenshot 2023-11-08 at 10 03 49 AM
@eu9ene eu9ene added the taskcluster Issues related to the Taskcluster implementation of the training pipeline label Nov 8, 2023
@eu9ene eu9ene added the tc-p1 Important Taskcluster issues to fix soon label Dec 22, 2023
@eu9ene eu9ene mentioned this issue Dec 22, 2023
Open
@gabrielBusta
Copy link
Member

I get a different message:
Screenshot 2024-01-12 at 13 03 41

@bhearsum
Copy link
Collaborator

bhearsum commented Feb 9, 2024

@jcristau and @gabrielBusta managed to fix the upstream issues in Taskgraph that were blocking this. I believe we now need to pick up the latest taskgraph version and apply taskcluster/taskgraph@31e0609 and taskcluster/taskgraph#459 to the .taskcluster.yml here to fix this issue.

@bhearsum
Copy link
Collaborator

bhearsum commented Feb 9, 2024

And also a small update to ci-configuration like this

@jcristau
Copy link

jcristau commented Feb 9, 2024

Was this issue about the cancel-all action in general, or specifically on a PR?

@bhearsum
Copy link
Collaborator

bhearsum commented Feb 9, 2024

Was this issue about the cancel-all action in general, or specifically on a PR?

Ah, it was about the action overall, heh. Well, we want actions in PRs as well...but that work won't help here 🤦‍♂️

@bhearsum bhearsum assigned bhearsum and unassigned gabrielBusta Mar 19, 2024
@bhearsum
Copy link
Collaborator

Made a small amount of progress here today. The y that is undefined is actually this taskGroup variable when you unminify it.

I know we've seen wonkiness trying to trigger actions from a group that was created by an action task - and I suspect that's what we're witnessing here as well.

bhearsum added a commit to bhearsum/taskcluster that referenced this issue Mar 20, 2024
@bhearsum
Ensure 'taskGroup' is always defined when fetching scopes for submitt…
5801c5d 
…ing an action task.

This is in support of making actions like "Cancel All" work on task groups that have been created by an Action Task (see mozilla/firefox-translations-training#250).

In an ideal world I'd like to understanding how `task.decisionTask` fits into things a bit more, and see if it could be removed...but that's more work than I'm willing to put in at the moment. I think this is a fairly safe fix to take in the meantime.
@bhearsum bhearsum mentioned this issue Mar 20, 2024
Merged
bhearsum added a commit to bhearsum/taskcluster that referenced this issue Mar 20, 2024
@bhearsum
Ensure 'taskGroup' is always defined when fetching scopes for submitt…
201aa4e 
…ing an action task.

This is in support of making actions like "Cancel All" work on task groups that have been created by an Action Task (see mozilla/firefox-translations-training#250).

In an ideal world I'd like to understanding how `task.decisionTask` fits into things a bit more, and see if it could be removed...but that's more work than I'm willing to put in at the moment. I think this is a fairly safe fix to take in the meantime.
bhearsum added a commit to bhearsum/taskcluster that referenced this issue Mar 20, 2024
@bhearsum
Ensure 'taskGroup' is always defined when fetching scopes for submitt…
e597943 
…ing an action task.

This is in support of making actions like "Cancel All" work on task groups that have been created by an Action Task (see mozilla/firefox-translations-training#250).

In an ideal world I'd like to understanding how `task.decisionTask` fits into things a bit more, and see if it could be removed...but that's more work than I'm willing to put in at the moment. I think this is a fairly safe fix to take in the meantime.
bhearsum added a commit to bhearsum/taskcluster that referenced this issue Mar 20, 2024
@bhearsum
Ensure 'taskGroup' is always defined when fetching scopes for submitt…
180fa31 
…ing an action task.

This is in support of making actions like "Cancel All" work on task groups that have been created by an Action Task (see mozilla/firefox-translations-training#250).

In an ideal world I'd like to understanding how `task.decisionTask` fits into things a bit more, and see if it could be removed...but that's more work than I'm willing to put in at the moment. I think this is a fairly safe fix to take in the meantime.
@bhearsum
Copy link
Collaborator

taskcluster/taskcluster#6917 is expected to fix this. It may be a week or two before it hits the Firefox CI cluster.

@bhearsum
Copy link
Collaborator

bhearsum commented Mar 28, 2024 •
edited

taskcluster/taskcluster#6917 is expected to fix this. It may be a week or two before it hits the Firefox CI cluster.

This half fixed things. The action does now work, but it uncovered an issue with some data being propagated when doing these steps:

  • Go to decision task group
  • Initiate a Train action
  • Navigate to one of the Tasks created from it
  • Go to that task's group
  • Use "Cancel All" from there

For the moment, this can be worked around by refreshing the new task group before using "Cancel All". I intend to fix the UI to make this unnecessary though.

@bhearsum bhearsum mentioned this issue Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhearsum bhearsum

Labels
taskcluster Issues related to the Taskcluster implementation of the training pipeline tc-p1 Important Taskcluster issues to fix soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bhearsum @eu9ene @jcristau @gabrielBusta