Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Telemetry reporting engine crashes #65

Closed
andrenatal opened this issue Feb 1, 2022 · 2 comments · Fixed by #68
Closed

Telemetry reporting engine crashes #65

andrenatal opened this issue Feb 1, 2022 · 2 comments · Fixed by #68
Assignees
@eu9ene

Comments

@andrenatal
Copy link
Contributor

We need to have telemetry reporting whenever the translation engine crashes or fail (re: browsermt/bergamot-translator#316). Are we capturing those @eu9ene ?
@eu9ene eu9ene mentioned this issue Feb 3, 2022
Merged
@eu9ene
Copy link
Collaborator

eu9ene commented Feb 3, 2022

At the moment any translation fail is reported without distinguishing between engine and non-engine. We have a metric in the schema to handle this. I'm adding it.

@andrenatal
Copy link
Contributor Author

Thanks @eu9ene . Code looks good to me, feel free to merge it after we can distinguish between the sources.

@eu9ene eu9ene closed this as completed in #68 Feb 3, 2022
jerinphilip pushed a commit to browsermt/bergamot-translator that referenced this issue Feb 9, 2022
@jelmervdl
Print errors by default in WASM build (#343)
80bd4e7 
* Remove BadHTML exception in favour of ABORT macro
   `ABORT()` gives us readable error messages, even when exception support is disabled.
* Control marian exception global setting in tests through fixture
* WASM: construct BlockingService with critical logging by default
   This log level is only used by ABORT()

See also: 
- mozilla/firefox-translations#65, 
- mozilla/firefox-translations#68
- mozilla/firefox-translations#70 
- mozilla/firefox-translations#56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eu9ene eu9ene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Record engine error in telemetry eu9ene/firefox-translations
2 participants
@andrenatal @eu9ene