Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Add alignment: soft; to YAML #53

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add alignment: soft; to YAML #53

merged 1 commit into from
Jan 27, 2022

Conversation

kpu
Copy link
Contributor

@kpu kpu commented Jan 26, 2022

This is required for HTML support to work.

This is required for HTML support to work.
@andrenatal
Copy link
Contributor

Which version of bergamot-translator is required to have for this flag? The one we are currently using is compatible with this? I'll let @abhi-agg review this

@kpu
Copy link
Contributor Author

kpu commented Jan 26, 2022

@kpu
Copy link
Contributor Author

kpu commented Jan 26, 2022

The HTML feature has always depended on this. So any quality of HTML you see in the extension until this is merged would indeed be terrible. Also, newer versions of the bergamot-translator code will throw an exception if HTML is on, HTML is seen in the request (the check is bypassed if only text appears), and alignment: soft is not configured at loading time.

This is making #51 even more crash-happy because even sending valid HTML will cause an error without this configured.

@abhi-agg abhi-agg merged commit d23f984 into mozilla:main Jan 27, 2022
@abhi-agg
Copy link
Collaborator

@andrenatal I verified that the artifacts that the extension currently uses already included this change. So, we are safe to merge it.

@andrenatal
Copy link
Contributor

andrenatal commented Jan 27, 2022

@abhi-agg does this fix #51 for free?

@abhi-agg
Copy link
Collaborator

@andrenatal It might fix the problem that you noticed in the extension pertaining to the bad quality of html translation before. We can start passing html content (instead of plain text) to the engine again for translation and re-evaluate the quality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants