Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Bug 1138481 - Add .pep8.rc with preferred settings to the repository #175

Closed
wants to merge 1 commit into from

Conversation

IamAdiSri
Copy link
Contributor

Bug 1138481

Created .pep8.rc file
Edited .travis.yml file

@IamAdiSri
Copy link
Contributor Author

@whimboo r?

@whimboo
Copy link
Contributor

whimboo commented May 21, 2015

Hey @IamAdiSri! Thank you for uploading the patch as PR. Sorry that I haven't had the time to check it earlier today. But I think I can wait with a deeper review given that the Travis CI test failed. This is something you will have to fix first. But let me have a look at it now.

max-line-length = 99
show-source = enable
statistics = enable
count = enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I have mentioned already on the bug in Bugzilla we don't want those three boolean keys included. Those are not necessary and seem to also cause the failure with Travis.

Bug 1138481

Created .pep8.rc file
Edited .travis.yml file
@IamAdiSri
Copy link
Contributor Author

@whimboo r?
Sorry about the typo. It was callous of me to not have checked the file before committing. The build seems to be okay now.

@whimboo
Copy link
Contributor

whimboo commented May 26, 2015

That looks great now. Thank you for the updates @IamAdiSri. I will get the commits squashed and merged immediately.

@whimboo
Copy link
Contributor

whimboo commented May 26, 2015

Merged as 9e20028.

@whimboo whimboo closed this May 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants