some newsletter front-end fixes

mozilla · Jun 28, 2013 · 2e0448e · 2e0448e
1 parent b5d24f7
commit 2e0448e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/hearth/media/css/site.styl b/hearth/media/css/site.styl
@@ -263,7 +263,6 @@ body {
         height: 75px;
         margin-top: 15px;
         width: 30px;
-        right: 0;
     }
 }
 
@@ -485,6 +484,10 @@ body {
         display: block;
     }
 
+    .newsletter {
+        display: none;
+    }
+
     @media $retina {
         #footzilla {
             background-image: url(../img/logos/footzilla-2x.png);

diff --git a/hearth/media/js/newsletter.js b/hearth/media/js/newsletter.js
@@ -13,8 +13,8 @@ define('newsletter',
     // Init newsletter signup checking system.
     function init() {
         // Toggle the conditions below if you want to test on Desktop.
-        if (!user.logged_in()) return;
-        //if (!user.logged_in() || !caps.firefoxOS || langs.indexOf(navigator.language) == -1) return;
+        //if (!user.logged_in()) return;
+        if (!user.logged_in() || langs.indexOf(navigator.language) == -1) return;
 
         var counter = +storage.getItem('newscounter');
         if (counter == 4) return;

diff --git a/hearth/templates/user/newsletter.html b/hearth/templates/user/newsletter.html
@@ -5,7 +5,7 @@ <h3>{{ _('Get Firefox Marketplace news') }}</h3>
     </header>
     <form class="news-signup-form">
       <p>
-        <input type="email" id="email" name="email" value="{{ email }}">
+        <input type="email" id="email" name="email" value="{{ email }}" required>
         <button class="button" type="submit">{{ _('Sign up') }}</button>
       </p>
       <p><a href="{{ url('privacy') }}">{{ _('Privacy Policy') }}</a></p>