Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mac support #10

Merged
merged 5 commits into from
Dec 6, 2019
Merged

Add Mac support #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97cb23e
Eliminate the `msg` closure from `Fixer::build_file_info`.
nnethercote Dec 4, 2019
a28cb41
Improve how input lines with bad files are handled.
nnethercote Dec 4, 2019
e134f41
Split up `build_file_info`.
nnethercote Dec 4, 2019
d088f9e
Change `FileInfo` field order.
nnethercote Dec 4, 2019
56bf73b
Add Mac support.
nnethercote Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 53 additions & 21 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 10 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,20 @@ license = "MIT/Apache-2.0"

[dependencies]
fxhash = "0.2.1"
goblin = "0.1.2"
regex = "1.0"
serde_json = "1.0"

# FIXME(https://github.com/mozilla/fix-stacks/issues/2): at the time of
# writing, 6.1.4 is the latest version of `symbolic` on crates.io, but this dev
# version of 7.0.0 fixes some API botches (`ObjectDebugSession::functions()`
# being private). Once 7.0.0 is released, we can switch to it.
symbolic-common = { git = "https://github.com/getsentry/symbolic/", rev = "d217a9340df3bbd373323b732880a95e6de353bf" }
symbolic-debuginfo = { git = "https://github.com/getsentry/symbolic/", rev = "d217a9340df3bbd373323b732880a95e6de353bf" }
symbolic-demangle = { git = "https://github.com/getsentry/symbolic/", rev = "d217a9340df3bbd373323b732880a95e6de353bf" }
#
# FIXME(https://github.com/mozilla/fix-stacks/issues/11): if/when my
# symbolic-debuginfo changes land
# (https://github.com/getsentry/symbolic/pull/173), change these to point again
# to the `getsentry` repo.
#
symbolic-common = { git = "https://github.com/nnethercote/symbolic/", rev = "7d4ca78958aab62104a9fc18bb17cdba616d7a63" }
symbolic-debuginfo = { git = "https://github.com/nnethercote/symbolic/", rev = "7d4ca78958aab62104a9fc18bb17cdba616d7a63" }
symbolic-demangle = { git = "https://github.com/nnethercote/symbolic/", rev = "7d4ca78958aab62104a9fc18bb17cdba616d7a63" }
9 changes: 4 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

This program post-processes ("fixes") the stack frames produced by
`MozFormatCodeAddress()`, which often lack one or more of: function name, file
name, line number. It relies on the `symbolic` crate to read debug info from
files.
name, line number. It relies on the `symbolic` and `goblin` crates to read
debug info from files.

It reads from standard input and writes to standard output. Lines matching the
special stack frame format are modified appropriately. For example, a line
Expand All @@ -24,10 +24,9 @@ the stack frames and the build files. Furthermore, the build files must not
have changed since the stack frames were produced. Otherwise, source locations
in the output may be missing or incorrect.

# Shortcomings
`fix-stacks` works on Linux, Windows, and Mac.

`fix-stacks` works on Linux and Windows. We aim to eventually support
[Mac](https://github.com/mozilla/fix-stacks/issues/3) and possibly Android.
# Shortcomings

On Linux, use with debuginfo sections in separate files is untested and
probably does not work.
Loading