Update to latest upstream symbolic and implement brekpad-to-native fallback #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes This fixes mozilla#38
…o was specified but is missing This fixes mozilla#40
|
Thanks Kris, I'll open a follow up bug to pull the new version into mozilla-central after merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes in this PR:
The macOS tests are failing because of a change that was introduced in upstream symbolic: this change modified the code used for parsing DWARF objects to ignore line entries starting at address 0. The reasoning behind the change is that those entries would be illegal per the DWARF spec and thus the debuginfo must be considered buggy. However, as it happens, our small macOS-specific test has just that kind of entries in the debuginfo. I tried recompiling it with more recent tools from Apple but to no avail.