Add support for arm64 macos #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Funnily enough, the mac tests were already busted... |
|
Test bustage is because of getsentry/symbolic#471 |
Gankra
suggested changes
Dec 17, 2021
|
Given our timezones, I'm assuming you won't see this until I'm on vacation at the end of the day, so I won't be available for re-review/discussion until January. |
glandium
force-pushed
the
arm64-macos
branch
from
ce56f15
to
203debc
Compare
|
ping |
gabrielesvelto
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
The basic idea makes sense, but I have some concerns with the details.
This all seems sensible to me, @Gankra do you still have any concerns with the above?
|
lgtm
…On Fri, Jan 28, 2022 at 1:47 AM Gabriele Svelto ***@***.***> wrote:
***@***.**** approved this pull request.
The basic idea makes sense, but I have some concerns with the details.
This all seems sensible to me, @Gankra <https://github.com/Gankra> do you
still have any concerns with the above?
—
Reply to this email directly, view it on GitHub
<#43 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIVRYHE4NKAR3XXQKEYLX3UYI3Z7ANCNFSM5KH7GHYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.