Add --local option to parse Android output. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
reviewed
Apr 4, 2023
mstange
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Oh, I appear to have merge rights in this repo! I didn't realize that.
This patch looks good to me. I'll commit my suggestion and merge it.
It occurred to me that this functionality can not only be used for remote-to-local remapping, but also for local-to-local remapping, for example if the symbols have moved. So the term "fallback directory" might also have been appropriate. But let's go with the "local" terminology for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually,
fix-stackscan resolve stack address when binary is in local machine. So we cannot use it for Android's unresolved stack due to remote. So I would like to add this support using new option (--local).Usages
adb logcat | fix-stacks --local /path/to/objdir/dist/bin