Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_advisory should ensures that there are no extra, unexpected fields in a file #55

Closed
mozfreddyb opened this issue Jun 3, 2020 · 1 comment · Fixed by #56
Closed

check_advisory should ensures that there are no extra, unexpected fields in a file #55

mozfreddyb opened this issue Jun 3, 2020 · 1 comment · Fixed by #56
Assignees
@jcristau @mozfreddyb

Comments

@mozfreddyb
Copy link
Collaborator

Current checks at https://github.com/mozilla/foundation-security-advisories/blob/master/check_advisories.py#L162 ensure that all the required fields are present in the files.

Inversely, we should ensure that there are no extra fields either, e.g., due to a nesting error we had a CVE section hidden below a CVE section
@mozfreddyb mozfreddyb self-assigned this Jun 3, 2020
jcristau added a commit to jcristau/foundation-security-advisories that referenced this issue Jun 3, 2020
@jcristau
check_advisories: validate advisories more thoroughly
9f493e4 
Use the schema library (https://pypi.org/project/schema/) to check for
expected fields and values.

Fixes mozilla#55
@mozfreddyb
Copy link
Collaborator Author

Julien beat me to it.

@mozfreddyb mozfreddyb reopened this Jun 3, 2020
jcristau added a commit to jcristau/foundation-security-advisories that referenced this issue Jun 3, 2020
@jcristau
check_advisories: validate advisories more thoroughly
18840a3 
Use the schema library (https://pypi.org/project/schema/) to check for
expected fields and values.

Fixes mozilla#55
@jcristau jcristau mentioned this issue Jun 3, 2020
Merged
jcristau added a commit that referenced this issue Jun 4, 2020
@jcristau
check_advisories: validate advisories more thoroughly
6f149f0 
Use the schema library (https://pypi.org/project/schema/) to check for
expected fields and values.

Fixes #55
rvandermeulen pushed a commit that referenced this issue Feb 1, 2023
@mozfreddyb @freddyb @rvandermeulen
Add advisories for Thunderbird 102.7.1 (#55)
c4c0fa4 
---------

Co-authored-by: Frederik Braun <fb@frederik-braun.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcristau jcristau

@mozfreddyb mozfreddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check_advisories: validate advisories more thoroughly jcristau/foundation-security-advisories
2 participants
@jcristau @mozfreddyb