uplift node to v12 (#4191)

Co-authored-by: Lucie <lucie.daeye@gmail.com>
MozillaFoundation · Feb 12, 2020 · e7d6907 · e7d6907
1 parent bdd752c
commit e7d6907
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -60,16 +60,16 @@ jobs:
         - coveralls
     - name: npm tests
       before_install:
-        - nvm install --lts=carbon
-        - nvm use --lts=carbon
+        - nvm install --lts=erbium
+        - nvm use --lts=erbium
       install: "./travis-scripts/npm-install.sh"
       script: npm test
     - name: Percy tests
       before_install:
         # libgconf is required by cypress
         - sudo apt-get install -y libgconf-2-4
-        - nvm install --lts=carbon
-        - nvm use --lts=carbon
+        - nvm install --lts=erbium
+        - nvm use --lts=erbium
       install:
         - "./travis-scripts/python-install.sh"
         - "./travis-scripts/npm-install.sh"

diff --git a/dockerfiles/Dockerfile.node b/dockerfiles/Dockerfile.node
@@ -1,4 +1,4 @@
-FROM node:8-stretch-slim
+FROM node:12-stretch-slim
 
 WORKDIR /app/
 

diff --git a/package.json b/package.json
@@ -69,7 +69,7 @@
     "whatwg-fetch": "^3.0.0"
   },
   "engines": {
-    "node": "^8.9.0"
+    "node": "12.x"
   },
   "devDependencies": {
     "browserslist": "^4.8.6",

diff --git a/travis-scripts/npm-install.sh b/travis-scripts/npm-install.sh
@@ -2,5 +2,4 @@
 
 set -x # echo commands before running them
 
-npm install -g npm@latest # Needed to use npm ci
 npm ci # Use package-lock.json