PNI Scaffolding #1804
Merged
PNI Scaffolding #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting bit of scrollbar on windows:
|
Pomax
reviewed
Sep 11, 2018
| </footer> | ||
| </body> | ||
| </html> | ||
| <script src="/_js/bg-main.compiled.js"></script> |
There was a problem hiding this comment.
technically this is invalid HTML since nothing's allowed to be between </body></html> or after </html> - given the current state of browsers, could we just move it to before </body> and mark it as defer so that it doesn't actually load until after the DOM has been fully parsed?
There was a problem hiding this comment.
Shouldn't matter, but sure.
| <div class="creepometer mb-5"></div> | ||
|
|
||
| <img src="{{mediaUrl}}{{product.image}}" width="500"/> | ||
| <div> |
There was a problem hiding this comment.
It feels like we've hit upon one of those few legitimate uses for <table> here =P
| @@ -16,3 +16,8 @@ def buyersguide_home(request): | |||
| def product_view(request, productname): | |||
| product = Product.objects.get(name__iexact=productname) | |||
| return render(request, 'product_page.html', {'product': product, 'mediaUrl': settings.MEDIA_URL}) | |||
|
|
|||
|
|
|||
| @login_required | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alanmoo – This is obviously a work in progress, but I figure it's better to land in chunks (and safe since it's non-visible to the public and fairly sandboxed).