Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump webpack from v3 to v4, with additional fixes to make that work. #1842

Merged
merged 3 commits into from Oct 1, 2018

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Sep 20, 2018

supersedes #1835

updates webpack from v3 to v4, with a change to the webpack config because module.loaders was renamed to module.rules. Small change, but dependabot has no way of knowing that. The CLI invocation was also taken out of webpack itself, so webpack-cli has been added to make sure we can still actually use webpack =)

@Pomax Pomax requested a review from gvn September 20, 2018 18:35
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1842 September 20, 2018 18:35 Inactive
@Pomax Pomax changed the title webpack update with associated config rewrite Bump webpack from v3 to v4, with additional fixes to make that work. Sep 20, 2018
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-1842 September 20, 2018 21:24 Inactive
Copy link
Contributor

@gvn gvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Pomax Pomax merged commit 773e066 into master Oct 1, 2018
@Pomax Pomax deleted the webpack-bump branch October 1, 2018 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants