Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get the majority vote values #1967

Merged
merged 1 commit into from Oct 18, 2018
Merged

get the majority vote values #1967

merged 1 commit into from Oct 18, 2018

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Oct 18, 2018 •
edited

Make sure the "majority" text values are based on the vote results.

closes #1966

@Pomax Pomax requested a review from alanmoo October 18, 2018 20:05
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-1967 October 18, 2018 20:05 Inactive
@Pomax Pomax changed the base branch from creepy-graph to master October 18, 2018 20:09
kristinashu
kristinashu approved these changes Oct 18, 2018
View reviewed changes
Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@kristinashu
Copy link

cc @mmmavis this might help you with the share text?

@alanmoo alanmoo merged commit 73663ce into master Oct 18, 2018
@Pomax Pomax deleted the majority-vote branch October 30, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinashu kristinashu kristinashu approved these changes

@alanmoo alanmoo Awaiting requested review from alanmoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buyers Guide: Creep-O-Meter result preview
4 participants
@Pomax @kristinashu @cadecairos @alanmoo