Added 'privacy_policy_reading_level_url' to Product model #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
previously requested changes
Oct 22, 2018
| @@ -20,6 +20,8 @@ export default class Criterion extends React.Component { | |||
| let meta = this.props.meta; | |||
| let fullClass = `criterion criterion-${meta.class} criterion-${meta.id}`; | |||
|
|
|||
| console.log(meta); | |||
mmmavis
commented
Oct 22, 2018
| @@ -191,6 +193,12 @@ class Product(models.Model): | |||
| max_length=2, | |||
| ) | |||
|
|
|||
| privacy_policy_reading_level_url = models.URLField( | |||
| max_length=2048, | |||
| help_text='Link to this privacy policy reading level', | |||
There was a problem hiding this comment.
@kristinashu let me know if help text for this the "reading level url" field makes sense... I don't know how to better describe it
Pomax
previously requested changes
Oct 22, 2018
|
kk I wasn't sure if I should update |
Pomax
reviewed
Oct 23, 2018
| @@ -29,7 +29,7 @@ export default class Criterion extends React.Component { | |||
| <button onClick={() => this.toggle()} className={this.state.helptextVisible ? `open` : `closed`}></button> | |||
| } | |||
| </p> | |||
| <p className="rating">{ meta.answer } <span className="emoji"></span></p> | |||
| <p className="rating"><span dangerouslySetInnerHTML={{__html: meta.answer}}></span> <span className="emoji"></span></p> | |||
There was a problem hiding this comment.
Filed #2006 to look at this later.
Pomax
approved these changes
Oct 23, 2018
|
Yes! Just checked it out on staging. This is perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1892