Redis Cache Backend #2037
Merged
Redis Cache Backend #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or variabled set by the Memcached Cloud Heroku add-on
|
ignore this, the memcached backend requires native libs that are screwing up testing. going to use a redis backend. |
cadecairos
changed the title
|
@Pomax this is ready for review now |
cadecairos
commented
Oct 24, 2018
| @@ -53,7 +53,7 @@ | |||
| ), | |||
| url(r'^cms/', include(wagtailadmin_urls)), | |||
| url(r'^documents/', include(wagtaildocs_urls)), | |||
| url('^sitemap\.xml$', sitemap) if settings.DEBUG else None, | |||
| url('^sitemap.xml$', sitemap) if settings.DEBUG else None, | |||
There was a problem hiding this comment.
updating the lockfile bumped the flake version, which caught this invalid escape pattern.
There was a problem hiding this comment.
oh neat O_o
... wait why did the sitemap work before? I guess it just goes ". doesn't need escaping, \. => ,"?
Pomax
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional Redis Cache backend.