Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier for css/scss #2807

Merged
merged 4 commits into from Mar 14, 2019
Merged

prettier for css/scss #2807

merged 4 commits into from Mar 14, 2019

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Mar 13, 2019

Closes #2805

All updates to (s)css files came from loading each file with errors flagged by prettier, and making prettier reformat them.

Note that this preserves stylelint as linter, since that can catch things that a pure formatter can't.

@Pomax Pomax requested review from mmmavis and youriwims March 13, 2019 21:50
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2807 March 13, 2019 21:51 Inactive
.stylelintrc Outdated Show resolved Hide resolved
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2807 March 14, 2019 16:41 Inactive
@Pomax Pomax requested a review from mmmavis March 14, 2019 16:41
Copy link
Contributor

@youriwims youriwims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@Pomax
Copy link
Contributor Author

Pomax commented Mar 14, 2019

just noticed this forgot to also include the networkapi dir (which has a few custom .css files) so I'll be updating the branch to include those, too

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2807 March 14, 2019 17:12 Inactive
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants