Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier for css/scss #2807

Merged
merged 4 commits into from Mar 14, 2019

Conversation

@Pomax
Copy link
Collaborator

commented Mar 13, 2019

Closes #2805

All updates to (s)css files came from loading each file with errors flagged by prettier, and making prettier reformat them.

Note that this preserves stylelint as linter, since that can catch things that a pure formatter can't.

@Pomax Pomax requested review from mmmavis and youriwims Mar 13, 2019

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2807 Mar 13, 2019 Inactive

.stylelintrc Outdated Show resolved Hide resolved

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2807 Mar 14, 2019 Inactive

@Pomax Pomax requested a review from mmmavis Mar 14, 2019

@youriwims
Copy link
Contributor

left a comment

🌟

@Pomax

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 14, 2019

just noticed this forgot to also include the networkapi dir (which has a few custom .css files) so I'll be updating the branch to include those, too

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2807 Mar 14, 2019 Inactive

@mmmavis
Copy link
Member

left a comment

@Pomax Pomax merged commit 9e6e52d into master Mar 14, 2019

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 74.627%
Details
percy/foundation.mozilla.org Visual review automatically approved, no visual changes found.
Details

@Pomax Pomax deleted the prettier branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.