Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating JS dev and prod dependencies #3241

Merged
merged 5 commits into from May 28, 2019
Merged

Separating JS dev and prod dependencies #3241

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e040d15
first try at separating dev dependencies from prod dependencies
May 27, 2019
bae3077
replace node_env var by npm_config_prod, which is used by Heroku
May 27, 2019
e3528ca
Merge branch 'master' into npm-dev
May 28, 2019
ff54e65
npm-run-all required for building
May 28, 2019
9b98de5
add package-lock.json
May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion app.json
View file
Open in desktop
Expand Up @@ -65,7 +65,8 @@
"CSP_CONNECT_SRC": "*",
"CSP_MEDIA_SRC": "'self'",
"CSP_CHILD_SRC": "'self'",
"CSP_FORM_ACTION": "'self' https://www.mozilla.org/en-US/newsletter/"
"CSP_FORM_ACTION": "'self' https://www.mozilla.org/en-US/newsletter/",
"NPM_CONFIG_PRODUCTION": "true"
},
"buildpacks": [
{
Expand Down
34 changes: 17 additions & 17 deletions package.json
View file
Open in desktop
Expand Up @@ -45,43 +45,28 @@
"author": "Mozilla",
"license": "MPL-2.0",
"dependencies": {
"autoprefixer": "^9.5.1",
"@babel/core": "^7.4.4",
"@babel/preset-env": "^7.4.4",
"@babel/preset-react": "^7.0.0",
"autoprefixer": "^9.5.1",
"babel-core": "^6.26.3",
"babel-loader": "^8.0.6",
"browserslist": "^4.6.0",
"chokidar-cli": "^1.2.2",
"classnames": "2.2.6",
"dotenv": "^8.0.0",
"eslint": "^5.16.0",
"eslint-config-prettier": "^4.3.0",
"eslint-plugin-prettier": "^3.1.0",
"eslint-plugin-react": "^7.13.0",
"event-stream": "3.3.4",
"html-entities": "^1.2.1",
"js-cookie": "2.2.0",
"mofo-bootstrap": "4.1.0",
"mofo-style": "^2.4.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we no longer uses mofo-style. I'll file a separate ticket to remove this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed: #3248

"moment": "^2.24.0",
"node-sass": "^4.12.0",
"npm-run-all": "^4.1.3",
"optipng-bin": "^5.1.0",
"postcss": "^7.0.16",
"postcss-cli": "^6.1.2",
"prettier": "^1.17.1",
"prop-types": "^15.7.2",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-ga": "2.5.7",
"shelljs": "^0.8.3",
"shx": "^0.3.2",
"snyk": "^1.163.3",
"stylelint": "^10.0.1",
"stylelint-config-standard": "^18.3.0",
"stylelint-prettier": "^1.1.0",
"svgo": "^1.2.2",
"webpack": "^4.32.0",
"webpack-cli": "^3.3.1",
"whatwg-fetch": "^3.0.0"
Expand All @@ -90,6 +75,21 @@
"node": "^8.9.0"
},
"devDependencies": {
"wait-on": "^3.2.0"
"browserslist": "^4.6.0",
"chokidar-cli": "^1.2.2",
"dotenv": "^8.0.0",
"eslint": "^5.16.0",
"eslint-config-prettier": "^4.3.0",
"eslint-plugin-prettier": "^3.1.0",
"eslint-plugin-react": "^7.13.0",
"npm-run-all": "^4.1.3",
"optipng-bin": "^5.1.0",
"prettier": "^1.17.1",
"wait-on": "^3.2.0",
"shelljs": "^0.8.3",
"stylelint": "^10.0.1",
"stylelint-config-standard": "^18.3.0",
"stylelint-prettier": "^1.1.0",
"svgo": "^1.2.2"
}
}