Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title casing enforcement of nav items #3516

Merged
merged 1 commit into from Aug 9, 2019
Merged

Conversation

alanmoo
Copy link
Contributor

@alanmoo alanmoo commented Aug 9, 2019

In the primary site navigation, "MozFest House" becomes "Mozfest House" and that's not good. Giving the users a little more freedom, with a minor cost (but everything that's in production already will look fine, so I don't think it's a concern.)

"MozFest" becomes "Mozfest" and that's not good. Giving the users a little more freedom, with a minor cost (but everything that's in production already will look fine, so I don't think it's a concern.)
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as long as people remember the capitalize their page titles correctly?

@alanmoo
Copy link
Contributor Author

alanmoo commented Aug 9, 2019

Yeah, they have been thus far. Plus if they don't, it'll be an obvious fix.

@alanmoo alanmoo merged commit 9e89c87 into master Aug 9, 2019
@alanmoo alanmoo deleted the alanmoo-patch-1 branch August 9, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants