Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PNI v4 2020 #5576

Closed
wants to merge 24 commits into from
Closed

[WIP] PNI v4 2020 #5576

wants to merge 24 commits into from

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Nov 5, 2020

All the homepage work

Pomax and others added 22 commits October 15, 2020 14:05
* make category page extend homepage template

* refactor further

* rename
* PNI hero changes

* styling fixes

* forgot to add image file
* 3 page types for PNI products

* Review/suggested changes
* Add created_date field to products

* Update.created_date field with default of Jan 1, 2020

* Default to Jan 1 2020, auto_now new Updates

* Update network-api/networkapi/buyersguide/migrations/0007_update_created_date.py

Co-authored-by: Pomax <pomax@nihongoresources.com>

* Update network-api/networkapi/buyersguide/pagemodels/product_update.py

Co-authored-by: Pomax <pomax@nihongoresources.com>

* Removed unused import

* Update network-api/networkapi/buyersguide/migrations/0007_update_created_date.py

Co-authored-by: Pomax <pomax@nihongoresources.com>

* Update network-api/networkapi/buyersguide/migrations/0007_update_created_date.py

Co-authored-by: Pomax <pomax@nihongoresources.com>

* Update network-api/networkapi/buyersguide/pagemodels/product_update.py

Co-authored-by: Pomax <pomax@nihongoresources.com>

* Migration fix

Co-authored-by: Pomax <pomax@nihongoresources.com>
* Orderables added to product pages

* Applied suggestions from code review

* Suggested review changes & migration fix
* make mobile primary nav work on PNI

* mobile active nav link

* fix regression - category nav should locate below the hero

* fix broken script

* remove extra padding around nav logo

* override default wide_screen_menu block content

* replace random z-index value with Bootstrap var
* Added borders

* I should know better by now

* Ran inv test-node

* Fixed top spacing for MSS ding
* initial functionality and super basic css

initial functionality and super basic css

...

...

linting

Update source/js/buyers-guide/search.js

Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>

Update source/js/buyers-guide/search.js

Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>

Update source/js/buyers-guide/search.js

Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>

* PR fixes

* refinements:

* pre-making-things-flex

* mostly done? This thing is kicking my ass...

* rogue console logs

* PR notes

* .

* Update admin.css

* Update __init__.py

* Delete search.svg

wrong icon

* Delete dismiss.svg

wrong icon

* recheck result count on pni-checkbox

* PR fixes... hopefully?

* .

* svgo

* svgo

* svgo

* 5423 search results (#5550)

* No search results w/ emoji

* Hide Submit A Product on category pages when no search results are found

* Ran inv test-node

* Code review fixes

* Update network-api/networkapi/buyersguide/templates/fragments/no_search_results.html

Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>

* Update network-api/networkapi/buyersguide/templates/fragments/no_search_results.html

Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>

Co-authored-by: Kalob Taulien <kalob.taulien@gmail.com>
Co-authored-by: Kalob Taulien <4743971+KalobTaulien@users.noreply.github.com>
Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>

* PR update

* localized string

* text sizing

Co-authored-by: Mavis Ou <mmmavis@users.noreply.github.com>
Co-authored-by: Kalob Taulien <kalob.taulien@gmail.com>
Co-authored-by: Kalob Taulien <4743971+KalobTaulien@users.noreply.github.com>
* repurpose foundation's site mobile 'multipage-nav' for PNI & add styling overrides to suit our needs

* design tweaks

* adjust mobile category nav's padding

* fix padding in another way
* updated the search bar to match the styling indicated in our new v4 designs

Co-authored-by: Kalob Taulien <kalob.taulien@gmail.com>
* Move creepo-face to bottom corner on scroll; fadein/fadeout

* Offset when creepo face is moved on desktop

* Move creepo-meter permanently when starting to ssearch on desktop

* Check if elements exist; moved node lookups; using class based lookups

* Fixes overlay bug on mobile
@mofodevops mofodevops temporarily deployed to foundation-s-pni-v4-202-7ggndg November 5, 2020 00:21 Inactive
* minor improvements

* minor improvements

* increase 'hit' area for icon
@Pomax Pomax temporarily deployed to foundation-s-pni-v4-202-7ggndg November 5, 2020 17:18 Inactive
@Pomax Pomax temporarily deployed to foundation-s-pni-v4-202-7ggndg November 5, 2020 17:46 Inactive
@Pomax Pomax closed this Nov 5, 2020
@Pomax Pomax deleted the pni-v4-2020 branch November 9, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants