New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#DearInternet - allow video embed only for videos on www.youtube.com #5923
Conversation
…& updated help text
…b.com/mozilla/foundation.mozilla.org into issue-5901-dearinternet-youtube-embed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use cases and styling look good!
The only thing that stands out is the text "Video url:" isn't changeable. Thinking ahead perhaps it would be more flexible if the label wasn't there or changeable so for use cases where we'd want to include a URL (to a website, image source etc.) it'd work too and not necessarily limited to video? I'd check with Audrey if we want label copy.
Good point. I'll just remove the label copy so that line stays unlabelled. My availability will be limited next week so I just wanna wrap up all my assigned dev work today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the label, that will do! 👍
@Pomax do you have the bandwidth to review this today? We are hoping to get this landed before the holiday shutdown. |
"Note that video embed will show only when the url is a valid YouTube video embed url. " | ||
"Go to your YouTube video and click “Share,” " | ||
"then “Embed,” and then copy and paste the provided URL only. " | ||
"For example: https://www.youtube.com/embed/s7OD5BgFrVM", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
Will assign code reviewer once this passes design review.
Allow video embed only for videos on https://www.youtube.com/embed and update help text
Closes #5901
Since it seems like we only have that one YouTube video we wanna show (so far, at least) and that this campaign is only till next Jan, I went with the simplest solution
Video url: [link to video url]
See test use cases on https://foundation-s-issue-5901-nsn6o5.herokuapp.com/en/campaigns/dearinternet/