Django 1.11 #970
Merged
Django 1.11 #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadecairos
commented
Jan 18, 2018
cadecairos
commented
- Use the lastest master branch commit of Mezzanine (Django 1.11 support)
- Update Django to 1.11
- Fix custom adminsortable template tags that were passing Context into the render method
- Remove deprecated Middleware
…port) 2. Update Django to 1.11 3. Fix custom adminsortable template tags that were passing Context into the render method 4. Remove deprecated Middleware
gideonthomas
approved these changes
Jan 18, 2018
| @@ -44,10 +51,13 @@ def render_object_rep( | |||
| obj, | |||
| forloop | |||
| ): | |||
| context.update({'object': obj, 'forloop': forloop}) | |||
| tmpl = template.loader.get_template( | |||
| '{app_name}/adminsortable_objects_custom.html'.format( | |||
| app_name=context.get('opts').app_label | |||
There was a problem hiding this comment.
this is still working?
There was a problem hiding this comment.
The trick was to pass opts along from context in every level of the template render, since it only accepts a plain dict.
cadecairos
pushed a commit
that referenced
this pull request
Jan 18, 2018
This reverts commit de4969e.
Merged
cadecairos
pushed a commit
that referenced
this pull request
Jan 18, 2018
Merged
alanmoo
added a commit
that referenced
this pull request
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.