Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs & FAQ #318

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Docs & FAQ #318

merged 4 commits into from
Aug 4, 2020

Conversation

hwine
Copy link
Contributor

@hwine hwine commented Aug 3, 2020

Replacement for #241, which got totally hosed somehow.

ATM, these docs build as html, but that isn't (yet) in the Makefile or CI. So this is a content only review

@hwine hwine requested review from g-k and ajvb August 3, 2020 23:10
Copy link
Contributor

@g-k g-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ lgtm

We could publish to RTD too.

@@ -18,7 +18,10 @@ jobs:
- run:
name: run tests
command: |
make black check_conftest_imports test coverage
source venv/bin/activate
# check_conftest_imports currently fails
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this uses ripgrep but could fallback to git grep or something else

=======

.. note::
The caching operations is under consideration for deprecation. If you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

- file, You can obtain one at https://mozilla.org/MPL/2.0/. -->

============================
Adding a New Service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@ajvb ajvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hwine!

I'd love to get these docs up on RTD or use github pages on this repo to make them viewable.

``resources.py``) are used to supply the data to tests. The tests are
conventionally written in ``test_<foo>.py`` files, with a single function of the
same name as the file. *(With "Black_", we stopped the tabs-vs-spaces debate,
so redirected that energy to one-or-many-tests-per-file debate.)*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

N.B. we require user to have sphinx installed globally at the moment.
That is somewhat reasonable, as Rust language uses sphinx for
documentation.

If we end up wanting specific sphinx extensions, we'll have to add
those requirements to a (not yet in existance) requirements-dev.txt.
@hwine hwine merged commit c8990b2 into master Aug 4, 2020
@hwine hwine deleted the FAQ branch August 4, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants