Bc/add keyring unlock #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't seem to actually fix the problem, we'll have to come back to this. |
Tracy-Walker
previously approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a fixture called
unlock_keyringwhich can be requested in tests that need an unlocked keyring. If a keyring password exists on the OS under test, the user will be prompted in the command line. This should not cause a problem for CI, as we will not set a keyring password there.Usage is just to add
unlock_keyringto the signature of any test function that needs it.Comments / Concerns
Created the possible future need for secrets management. Not implemented for Linux or Windows.