hy/google search counts us #74
Open
+80
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-c-at-moz
requested changes
Jun 21, 2024
|
One more thing, I'm going to need you to merge main before I can approve the PR |
added 3 commits
June 25, 2024 11:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test ensures that search count telemetry data is collected accordingly for Google.
Bugzilla bug ID
ID: 1902774
Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1902774
Type of change
Please delete options that are not relevant.
How does this resolve / make progress on that bug?
Completed.
Screenshots / Explanations
N/A.
Comments / Concerns
Created a POM for about:telemetry with a function to decode url to base64
Created a function in BasePage to switch tab.
Created a test for google search count, I used jsonpath-ng 1.6.1 to parse the json.
I had to use time.sleep() after the search otherwise both of the telemetries weren't displayed.