This repository has been archived by the owner on Mar 20, 2022. It is now read-only.
fix(fn): don't send identify data to the http api #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbooth
force-pushed
the
phil/wrong-endpoint
branch
from
3ba6bde
to
b1e1507
Compare
jbuck
approved these changes
Sep 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Splits out
$appendverbs for sending to the Identify API, leaving everything else to continue as before to the HTTP API. There is some rudimentary batching logic which keeps batch size for the Identify API less than or equal to batch size for the HTTP API.@jbuck r? / want to give it a try in stage?