Skip to content
This repository has been archived by the owner on Jul 12, 2018. It is now read-only.

Add travis config file #10

Merged
merged 2 commits into from Sep 22, 2014
Merged

Add travis config file #10

merged 2 commits into from Sep 22, 2014

Conversation

fmarier
Copy link

@fmarier fmarier commented Sep 22, 2014

No description provided.

language: node_js

node_js:
- 0.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be in quotes, otherwise it was screwing up something with rounding down to 0.1, iirc. /cc @jrgm

@fmarier
Copy link
Author

fmarier commented Sep 22, 2014

@pdehaan I've addressed both of your comments.

@fmarier
Copy link
Author

fmarier commented Sep 22, 2014

@pdehaan should we do the same in the customs server? I copied its .travis.yml into the auth-mailer.

@pdehaan
Copy link
Contributor

pdehaan commented Sep 22, 2014

@fmarier Sorry, I'm an idiot. We don't need to add --depth 0 since it's calling npm run outdated which is a script in package.json which adds the depth for us. No need to tweak customs server.

Sorry, I have failed you.

@pdehaan
Copy link
Contributor

pdehaan commented Sep 22, 2014

FWIW, here was the 0.10 vs "0.10" issue I was remembering: travis-ci/travis-ci#977

Not sure if that's super valid or if they've addressed it somehow as it looks like fxa-customs-server/.travis.yml specifies 0.10 (no quotes), but the Travis logs show:

$ node --version # v0.10.32
$ npm --version # 1.4.28

@fmarier
Copy link
Author

fmarier commented Sep 22, 2014

Alright, let's give it a go like this.

fmarier pushed a commit that referenced this pull request Sep 22, 2014
@fmarier fmarier merged commit 85988d0 into mozilla:master Sep 22, 2014
@pdehaan
Copy link
Contributor

pdehaan commented Sep 22, 2014

MERGE ALL THE THINGS!

@fmarier fmarier deleted the add-travis branch September 22, 2014 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants