Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Enable timestamp checking in Hawk #199

Closed
ckarlof opened this issue Sep 13, 2013 · 3 comments
Closed

Enable timestamp checking in Hawk #199

ckarlof opened this issue Sep 13, 2013 · 3 comments

Comments

@ckarlof
Copy link
Contributor

ckarlof commented Sep 13, 2013

No description provided.

@vladikoff
Copy link
Contributor

Does this cause the Unauthorized errors?

{"code":401,"error":"Unauthorized","message":"Bad mac","errno":401}

I'm trying to switch the tests to run using local picl-idp. However I'm getting errors:

@rfk
Copy link
Contributor

rfk commented Oct 28, 2013

It's not clear what this bug is actually asking for. AFAICT hawk has timestamp-checking enabled by default. Two possibly-related things we need to consider:

  • By default it accepts a clock skew of +/- 60 seconds between client and server. Do we want to tweak this? It seems tight enough for me, given our desired to correct this client-side per Return server timestamp in all (or just certificate/sign) responses #233
  • AFAICT hawk does not check for re-use of nonces by default. You have to supply a custom nonce-checking function, and hapi doesn't seem to have a default. We should definitely add this.

I filed #253 to track the later. What else needs to be done for this bug?

@ckarlof
Copy link
Contributor Author

ckarlof commented Oct 28, 2013

Yes we can close this. I think there some confusion about whether clock skew/timestamp checking is configured and enabled. @zaach seemed to think it wasn't. We should have a test to verify that timestamp check is enabled and works. Closing this bug in favor of that (#255).

@ckarlof ckarlof closed this as completed Oct 28, 2013
rfk pushed a commit that referenced this issue Oct 24, 2018
Only blank and application/json are allow.

Closes #199
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants