Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Do direct assertion->token exchange on the /token endpoint, not the /authorization endpoint #2962

Closed
shane-tomlinson opened this issue Mar 13, 2019 · 2 comments · Fixed by #2969
Assignees

Comments

@shane-tomlinson
Copy link

From @rfk's comment in #2955 (comment) which I agree with:


IMHO, we should stop doing implicit grants on the /authorization endpoint and start doing them on the /token endpoint, since our client apps only use this flow for granting tokens to themselves (which is what the /token endpoint is conceptually about) rather than to other clients (which is what the /authorization endpoint is conceptually about).

Obviously there's b/w compat concerns there though, so let's see how it shakes it in practice...


Another win is that /authorization endpoint validation logic simplifies considerably.

@rfk
Copy link
Contributor

rfk commented Mar 15, 2019

Taking this, as I've been working on a related cleanup for #2954 anyway

@rfk rfk changed the title Issue implicit grants from the /token endpoint instead of the /authorization endpoint Issue direct credential grants from the /token endpoint instead of the /authorization endpoint Mar 15, 2019
@rfk
Copy link
Contributor

rfk commented Mar 15, 2019

Also we should stop calling them "implicit grants" because "implicit grant" means a very specific thing in the OAuth world, and that thing is not the same as the thing we're doing.

@rfk rfk changed the title Issue direct credential grants from the /token endpoint instead of the /authorization endpoint Do direct assertion->token exchange on the /token endpoint, not the /authorization endpoint Mar 15, 2019
@rfk rfk closed this as completed in #2969 Mar 27, 2019
@ghost ghost removed the waffle:review label Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants