Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

handle client clock skew in fxa issued assertions #347

Closed
lloyd opened this issue Nov 21, 2013 · 6 comments
Closed

handle client clock skew in fxa issued assertions #347

lloyd opened this issue Nov 21, 2013 · 6 comments
Assignees

Comments

@lloyd
Copy link
Contributor

lloyd commented Nov 21, 2013

Is there a mechanism to handle deviant client clocks in FxA?

in persona we deliver server time to the client in an inital API request. That request also contains many other goodies that can be batched up front and facilitate various future interactions (CSRF, and more).

We've also experience issues (especially on FxOS) when we infrequently calculate clock delta (@jedp has deets).

This issue can be closed when there is a reliable way to ensure that a FxA issued assertion will be accepted by a verifier with an NTP sync'd clock within 10s of reality.

@rfk
Copy link
Contributor

rfk commented Nov 22, 2013

The persona.org context blob, for reference: https://github.com/mozilla/persona/blob/dev/lib/wsapi/session_context.js#L64

@rfk
Copy link
Contributor

rfk commented Nov 22, 2013

I'm a tentative +1 on doing a similar thing in FxA, perhaps subsuming the functionality of the /v1/get_random_bytes endpoint. Is there other data we could profitably include this this blob?

An alternative we've discussed is to send a "Timestamp" header in all responses. Advantage being that you don't need a separate round-trip to fetch this information.

@lloyd
Copy link
Contributor Author

lloyd commented Nov 25, 2013

Yeah, that makes sense. The timestamp in every response is an interesting idea that would let you solve the problem of long running sessions being vulnerable to skew.

@rfk
Copy link
Contributor

rfk commented Nov 28, 2013

Let's do the Timestamp header for now, we should consider the broader idea of a "context blob" as part of the longer-term API.

@SamPenrose
Copy link

@rfk
Copy link
Contributor

rfk commented Dec 3, 2013

Fixed in #362

@rfk rfk closed this as completed Dec 3, 2013
rfk pushed a commit that referenced this issue Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants