Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

awkward use of path.join #457

Closed
pdehaan opened this issue Dec 20, 2013 · 1 comment
Closed

awkward use of path.join #457

pdehaan opened this issue Dec 20, 2013 · 1 comment

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Dec 20, 2013

  1. /test/run/signer_tests.js#L8
    var signer = new CC({ module: path.join(__dirname, '../signer-stub.js')})
  2. /test/run/verification_tests.js#L12
    process.env.CONFIG_FILES = path.join(__dirname, '../config/verification.json')

We should probably do something like so:

  1. var signer = new CC({ module: path.join(__dirname, '..', 'signer-stub.js')})
  2. process.env.CONFIG_FILES = path.join(__dirname, '..', 'config', 'verification.json')
@dannycoates
Copy link
Contributor

not broken, not improved readability, and good enough for the node docs http://nodejs.org/api/path.html#path_path_join_path1_path2

wontfix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants