This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(deps): shrinkwrap excludes fxa-jwtool->pem-jwk dep if pem-jwk is a devDep #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgm
force-pushed
the
fix-pem-jwk-install
branch
from
ce31c66
to
455a8e0
Compare
jrgm
force-pushed
the
fix-pem-jwk-install
branch
from
455a8e0
to
08f0dca
Compare
dannycoates
added a commit
that referenced
this pull request
Oct 21, 2015
fix(deps): shrinkwrap excludes fxa-jwtool->pem-jwk dep if pem-jwk is a devDep
@dannycoates pointed out that we could just drop pem-jwk as a devDep and alter the one dev use to find the module under fxa-jwtool, which is what was done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? - @dannycoates
Demonstrated here. Doesn't make sense to me, but that's the way npm@2 does things.
So, falsely promote pem-jwk to a top-level dependency and be done with it.
I'll cherry-pick this back to v1.48.1 if this looks good to you.