This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(metrics): ensure email sent amplitude events include device id #2763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to mozilla/fxa-activity-metrics#109.
Currently our
fxa_email - sent
amplitude events do not include the device id, which may be causing problems with the funnels with Amplitude. This change fixes it by passing the device id to the mailer in our sign-in, sign-up and reset flows, and also by setting the property on the correct object when calling the amplitude module.Here is an example event from before these changes (without
device_id
):And here is an example event after these changes (with
device_id
):Opened against
train-126
for a patch release as it's affecting metrics.@mozilla/fxa-devs r?