Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

twerking the tests a bit and converting tabs to [2] spaces #345

Merged
merged 1 commit into from Nov 21, 2013

Conversation

pdehaan
Copy link
Contributor

@pdehaan pdehaan commented Nov 21, 2013

  • Converted tabs to spaces.
  • Excluded 1 vendor JS file from JSHint since it was a bit noisy.

We should now be down to only a small handful of JSHint warnings:

$ grunt jshint
Running "jshint:files" (jshint) task
Linting test/run/account_reset_token_tests.js ...ERROR
[L110:C33] W116: Expected '!==' and instead saw '!='.
          while (newSRPv.length != 512) {
Linting test/run/integration_tests.js ...ERROR
[L6:C9] W098: 'path' is defined but never used.
var path = require('path')
Linting test/run/integration_tests.js ...ERROR
[L30:C13] W098: 'email5' is defined but never used.
  var email5 = uniqueID() + "@example.com"
Linting test/run/raw_password_tests.js ...ERROR
[L25:C13] W098: 'email2' is defined but never used.
  var email2 = uniqueID() + "@example.com"
Linting test/run/raw_password_tests.js ...ERROR
[L26:C13] W098: 'email3' is defined but never used.
  var email3 = uniqueID() + "@example.com"
Linting test/run/session_token_tests.js ...ERROR
[L6:C11] W098: 'crypto' is defined but never used.
var crypto = require('crypto')
Linting tokens/srp_token.js ...ERROR
[L5:C11] W098: 'crypto' is defined but never used.
var crypto = require('crypto')

Warning: Task "jshint:files" failed. Use --force to continue.

Aborted due to warnings.

I'll do a separate PR for removing those unused require() statements and commenting out those unused test users.

@rfk
Copy link
Contributor

rfk commented Nov 21, 2013

twerking the tests

o_O

I wonder if you can expense one of those giant foam hands...

rfk added a commit that referenced this pull request Nov 21, 2013
twerking the tests a bit and converting tabs to [2] spaces
@rfk rfk merged commit eff946a into mozilla:master Nov 21, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants