This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Stop logging config when NODE_ENV=production #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ |
rfk
added a commit
that referenced
this pull request
Nov 26, 2013
Stop logging config when NODE_ENV=production
|
A bit out of scope for this repo, but do we need a similar logging config to handle the following? (There is no equivalent logging for fxa-scrypt-helper, as far as I can tell...) |
|
@jbonacci I think it makes sense to standardize logging across all repos |
This was referenced Nov 26, 2013
rfk
pushed a commit
that referenced
this pull request
Oct 24, 2018
fix(config): update config to use getProperties
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to implement something easy before I slit my wrists (figuratively) over UTF8, API changes, crypto, and Thanksgiving at the in-laws.
@rfk r?
Closes #298