basket api notifier

[dannycoates]

Adds a new process for sending verified email addresses to the Basket API.

New Config

basket: {
  region: 'The region where the queues live',
  apiUrl: 'Url for the Basket API server',
  apiKey:  'Basket API key',
  queueUrl: 'The bounce queue URL'
}

New Deployment

This requires a new SQS queue that gets fed by the existing auth-server events SNS topic. The new node process bin/basket.js empties the queue.

[dannycoates]

The SQS bits shared by email_bouncer.js and basket.js will be moved out as a module and each process will eventually become a separate repo.

[rfk]

Particularly given the opaque name "basket", this file could use a high-level introductory comment to explain WTF it is for. Even just a couple of lines like Send details of account activity to engagment team using their "basket" API and a link to their wiki page or whatever.

[rfk]

LGTM overall

[ckarlof]

@dannycoates, given that we need to eventually notify them of legacy accounts created before we deploy this, do we have a way to distinguish between accounts that we've already notified them about vs ones we haven't?

[dannycoates]

do we have a way to distinguish between accounts that we've already notified them about vs ones we haven't?

We have the createdAt date of the account. My plan was to backfill verified accounts created before notifier was deployed from most recently created to least. If the launch goes well that should be all we need.

If the launch doesn't go as smoothly as we hope we may need to get more crafty. In the worst case we can parse the notifier log to build a list of emails that succeeded then go through all the accounts again. I don't think we should be storing anything in the auth-server db for this.

Also it seems like the basket api will do an update if the email already exists, so it might be ok if an email gets registered multiple times, but it looks like an email might get sent in that case also https://github.com/mozilla/basket/blob/master/news/tasks.py#L311

@pmclanahan what happens if an email gets /news/fxa-registered twice?

[ckarlof]

Thanks Danny. SGTM.

[pmclanahan]

@pmclanahan what happens if an email gets /news/fxa-registered twice?

Currently they would get the welcome message again. We could easily make it skip sending the message if the user already had an fxa_id in basket.