Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Accounts l10n content on staging not up to date #320

Closed
peiying2 opened this issue Jan 21, 2019 · 7 comments
Closed

Firefox Accounts l10n content on staging not up to date #320

peiying2 opened this issue Jan 21, 2019 · 7 comments
Assignees

Comments

@peiying2
Copy link
Contributor

peiying2 commented Jan 21, 2019

@rfk Our localizer @jordis reported that the dev site has not been up to date to reflect what's translated in Pontoon. https://pontoon.mozilla.org/ca/firefox-accounts/. This is what we have on Pontoon for the FxA project: https://pontoon.mozilla.org/projects/firefox-accounts/info/. Has the info changed or do we have a sync issue?

@rfk
Copy link
Contributor

rfk commented Jan 21, 2019

Thanks @peiying2, I'm going to defer to @shane-tomlinson here who is the lead engineer on FxA these days.

@shane-tomlinson
Copy link
Contributor

@peiying2, @jordis - which dev site? I can have a look, but want to look at the same thing as you.

@shane-tomlinson shane-tomlinson removed their assignment Jan 22, 2019
@shane-tomlinson
Copy link
Contributor

Doh, staging.

@shane-tomlinson
Copy link
Contributor

https://accounts.stage.mozaws.net/ver.json

{
  "commit": "a0249ac4a1a5627a62c1fb8cc904670bae7e7fe5",
  "version": "1.128.1",
  "l10n": "fd2e4d67f7ef582f1154d73e2342c6caa22bda18",
  "tosPp": "7620b391f9473d41a70f2c9226469073025fc6fe",
  "source": "https://github.com/mozilla/fxa-content-server"
}

That l10n commit is from 12 days ago:

fd2e4d6

This makes sense. The git SHA for the strings is chosen a few days before the deployment so that a full prod-like stack can be tested end to end. The train-128 deployment was scheduled for Jan 14th, Jan 10th was the Thursday before it, which would have given the Thursday/Friday and weekend to test.

Today is the train-129 tag so any strings updated after Jan 10th will be on stage within the next few days.

https://stable.dev.lcip.org integrates string changes more frequently:

{
  "commit": "d28a13fd3d2ad4c2b4b95ee664e64a84f740e493",
  "version": "1.128.1",
  "l10n": "ba20bf25b35acea4fa880d8c726d5b9c405c0273",
  "tosPp": "7620b391f9473d41a70f2c9226469073025fc6fe",
  "source": "https://github.com/mozilla/fxa-content-server"
}

The git SHA used there is from Jan 15th. Not fully up to date, but closer.

@jrgm is this an accurate representation of how you pull in strings? Do the strings on stable auto-update?

@shane-tomlinson
Copy link
Contributor

@jrgm to investigate why stable didn't pull in the new strings on Thursday.

@shane-tomlinson
Copy link
Contributor

It did. On Thursday @ 4pm Pacific. Closing.

@jordis
Copy link
Contributor

jordis commented Jan 30, 2019

This issue is closed but I cannot see the localized strings in the staging server https://latest.dev.lcip.org/
All strings are in English. Is this working as designed? @peiying2 @shane-tomlinson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants