Merge pull request #1893 from mozilla/issue-1891-signup-focus

fix(client): Autofocus on /signup works again.
mozilla · Nov 14, 2014 · 8093d8f · 8093d8f
2 parents 8e1b488 + 7f14242
commit 8093d8f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/app/scripts/views/sign_up.js b/app/scripts/views/sign_up.js
@@ -80,6 +80,8 @@ function (_, p, BaseView, FormView, Template, Session, AuthErrors,
         this.showValidationError('input[type=email]',
                   AuthErrors.toError('DIFFERENT_EMAIL_REQUIRED'));
       }
+
+      return FormView.prototype.afterVisible.call(this);
     },
 
     events: {

diff --git a/app/tests/spec/views/sign_up.js b/app/tests/spec/views/sign_up.js
@@ -174,6 +174,21 @@ function (chai, _, $, moment, sinon, p, View, Session, AuthErrors, Metrics,
             assert.isTrue(view.showValidationError.called);
           });
       });
+
+      it('focuses the email element by default', function (done) {
+        $('html').addClass('no-touch');
+        TestHelpers.requiresFocus(function () {
+          view.render()
+            .then(function () {
+
+              view.$('input[type="email"]').one('focus', function () {
+                done();
+              });
+
+              view.afterVisible();
+            });
+        }, done);
+      });
     });
 
     describe('isValid', function () {