"You are signed in as" is always displayed in English

[flodolo]

I'd blame this change from @shane-tomlinson
f799ebf

Considering we're less than 2 days from launching Australis, is there any way to get this fixed reusing the previous string?

[flodolo]

Let me know if I need to file a bug instead of an issue. Personally I think this change is a step back in terms of localizability.

If I understand the code correctly, localizers lost the ability to move "email" around in the string, you shouldn't assume that all locales can deal with the email at the end like this.

[pdehaan]

I think this is a dupe of #997 Missing translations on the /settings page.

/cc @zaach

[zaach]

@pdehaan Yes. What I didn't realize in #997 is that this is also a problem on stage, not just accounts-latest. Which means string changes went into train-11 that weren't in our last string extraction. 😦
(In hindsight, we should have run a fresh extraction after the cut of train-11. We ended up with a week old strings instead, perhaps due to the confusion.)

Of the missing strings, we might be able to hot patch minimal string changes like the one in this issue. Here are the other minimally changed strings:

Attempt limit exceeded.
"Attempt limit exceeded. Try again later."

Server busy, try again soon
System unavailable, try again soon
"Service unavailable"

You are now ready to use %(serviceName)s.
"You are now ready to use %(service)s."

You are signed in as
"You are signed in as: %(email)s"

And for this one:

missing search parameter: %(itemName)s

We have strings for individual parameters:

"No token specified"
"No code specified"
"No email specified"
"No uid specified"

_The rest of the new strings are mostly related to error states._

Cookie related:

Try again
Cookies Required
Cookies are still disabled
Learn more
Please enable cookies in your browser which are required by Firefox Accounts. Cookies are small pieces of data stored in your browser that provide functionality such as remembering you between sessions.

Password reset/sign up confirmation link errors:

Click here to receive a new reset link
The link you clicked to reset your password is expired.
The link you clicked was missing characters, and may have been broken by your email client. Copy the address carefully, and try again.
Verification error
Verification link damaged
Verification link expired

5xx pages:

We are currently performing some maintenance on the system, and will return momentarily.
We are currently under heavy strain and are working to return the system to normal as soon as possible.

Misc:

You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.
Firefox Sync

💣 💣 💣

[zaach]

/cc @jrgm

[zaach]

Here's a commit that reverts the string @flodolo mentions and a few more straightforward ones, if we decide to go that route: https://github.com/mozilla/fxa-content-server/commits/revert-strings

[pdehaan]

Fixed via #1022. Closing.